summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAntonino A. Daplas <adaplas@gmail.com>2006-06-26 09:26:44 +0200
committerLinus Torvalds <torvalds@g5.osdl.org>2006-06-26 18:58:31 +0200
commit17cc6281c12b26425209c58e3d8825a9568db3cc (patch)
treead5d9b0dc35765e7d2ae8c7d53784531ba1e690f
parent[PATCH] fbdev: Coverity Bug 85 (diff)
downloadlinux-17cc6281c12b26425209c58e3d8825a9568db3cc.tar.xz
linux-17cc6281c12b26425209c58e3d8825a9568db3cc.zip
[PATCH] fbdev: Coverity Bug 90
It's a false positive, but let's suppress it anyway. Signed-off-by: Antonino Daplas <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--drivers/video/modedb.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/video/modedb.c b/drivers/video/modedb.c
index 1aa36d302a51..7e539b69a9a2 100644
--- a/drivers/video/modedb.c
+++ b/drivers/video/modedb.c
@@ -791,8 +791,9 @@ struct fb_videomode *fb_find_best_mode(struct fb_var_screeninfo *var,
if (diff > d) {
diff = d;
best = mode;
- } else if (diff == d && mode->refresh > best->refresh)
- best = mode;
+ } else if (diff == d && best &&
+ mode->refresh > best->refresh)
+ best = mode;
}
}
return best;