summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2019-08-09 14:42:30 +0200
committerTheodore Ts'o <tytso@mit.edu>2019-10-21 15:16:46 +0200
commit6d69843e5d3f0c394e1e3004cc2b36efbe402b71 (patch)
tree6407b6e7b5d52fdaad7864865365e3798f55a4b3
parentjbd2: Move dropping of jh reference out of un/re-filing functions (diff)
downloadlinux-6d69843e5d3f0c394e1e3004cc2b36efbe402b71.tar.xz
linux-6d69843e5d3f0c394e1e3004cc2b36efbe402b71.zip
jbd2: Drop unnecessary branch from jbd2_journal_forget()
We have cleared both dirty & jbddirty bits from the bh. So there's no difference between bforget() and brelse(). Thus there's no point jumping to no_jbd branch. Signed-off-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20190809124233.13277-5-jack@suse.cz Signed-off-by: Theodore Ts'o <tytso@mit.edu>
-rw-r--r--fs/jbd2/transaction.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 620113068e03..2d42bc42933e 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -1599,10 +1599,6 @@ int jbd2_journal_forget (handle_t *handle, struct buffer_head *bh)
} else {
__jbd2_journal_unfile_buffer(jh);
jbd2_journal_put_journal_head(jh);
- if (!buffer_jbd(bh)) {
- spin_unlock(&journal->j_list_lock);
- goto not_jbd;
- }
}
spin_unlock(&journal->j_list_lock);
} else if (jh->b_transaction) {