diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 13:06:24 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-09-26 17:22:40 +0200 |
| commit | 752c938a5c14b8cbf0ed3ffbfa637fb166255c3f (patch) | |
| tree | fa6bb1e5da7c9344616675e4870cdfad45b5fc30 | |
| parent | ASoC: soc-component: fix a couple missing error assignments (diff) | |
| download | linux-752c938a5c14b8cbf0ed3ffbfa637fb166255c3f.tar.xz linux-752c938a5c14b8cbf0ed3ffbfa637fb166255c3f.zip | |
ASoC: topology: Fix a signedness bug in soc_tplg_dapm_widget_create()
The "template.id" variable is an enum and in this context GCC will
treat it as an unsigned int so it can never be less than zero.
Fixes: 8a9782346dcc ("ASoC: topology: Add topology core")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20190925110624.GR3264@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/soc-topology.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/soc-topology.c b/sound/soc/soc-topology.c index b8690715abb5..c25939c5611b 100644 --- a/sound/soc/soc-topology.c +++ b/sound/soc/soc-topology.c @@ -1588,7 +1588,7 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg, /* map user to kernel widget ID */ template.id = get_widget_id(le32_to_cpu(w->id)); - if (template.id < 0) + if ((int)template.id < 0) return template.id; /* strings are allocated here, but used and freed by the widget */ |