diff options
| author | Akinobu Mita <akinobu.mita@gmail.com> | 2010-08-27 18:41:56 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-08-29 00:37:03 +0200 |
| commit | 762c29164e2850d8c5e4c258cef0077b2584d111 (patch) | |
| tree | 4cb5c25ce87578386f751dbcd3e46b6eba3cb716 | |
| parent | slip: Use net_device_stats from struct net_device (diff) | |
| download | linux-762c29164e2850d8c5e4c258cef0077b2584d111.tar.xz linux-762c29164e2850d8c5e4c258cef0077b2584d111.zip | |
econet: kill unnecessary spin_lock_init()
The spinlock aun_queue_lock is initialized statically. It is unnecessary
to initialize by spin_lock_init() at module load time.
This is detected by the semantic patch.
// <smpl>
@def@
declarer name DEFINE_SPINLOCK;
identifier spinlock;
@@
DEFINE_SPINLOCK(spinlock);
@@
identifier def.spinlock;
@@
- spin_lock_init(&spinlock);
// </smpl>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Julia Lawall <julia@diku.dk>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/econet/af_econet.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/econet/af_econet.c b/net/econet/af_econet.c index dc54bd0d083b..baa98fb83552 100644 --- a/net/econet/af_econet.c +++ b/net/econet/af_econet.c @@ -1009,7 +1009,6 @@ static int __init aun_udp_initialise(void) struct sockaddr_in sin; skb_queue_head_init(&aun_queue); - spin_lock_init(&aun_queue_lock); setup_timer(&ab_cleanup_timer, ab_cleanup, 0); ab_cleanup_timer.expires = jiffies + (HZ*2); add_timer(&ab_cleanup_timer); @@ -1167,7 +1166,6 @@ static int __init econet_proto_init(void) goto out; sock_register(&econet_family_ops); #ifdef CONFIG_ECONET_AUNUDP - spin_lock_init(&aun_queue_lock); aun_udp_initialise(); #endif #ifdef CONFIG_ECONET_NATIVE |