summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPan Bian <bianpan2016@163.com>2016-12-04 06:45:15 +0100
committerDavid S. Miller <davem@davemloft.net>2016-12-05 20:53:46 +0100
commit7cf6156633b71743c09a8e56b1f0dedfc4ce6e66 (patch)
tree1bc2fbae1faa65d9f583c81bb6e348b91df6d19f
parentnet: irda: set error code on failures (diff)
downloadlinux-7cf6156633b71743c09a8e56b1f0dedfc4ce6e66.tar.xz
linux-7cf6156633b71743c09a8e56b1f0dedfc4ce6e66.zip
atm: fix improper return value
It returns variable "error" when ioremap_nocache() returns a NULL pointer. The value of "error" is 0 then, which will mislead the callers to believe that there is no error. This patch fixes the bug, returning "-ENOMEM". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189021 Signed-off-by: Pan Bian <bianpan2016@163.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/atm/eni.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c
index f2aaf9e32a36..40c2d561417b 100644
--- a/drivers/atm/eni.c
+++ b/drivers/atm/eni.c
@@ -1727,7 +1727,7 @@ static int eni_do_init(struct atm_dev *dev)
printk("\n");
printk(KERN_ERR DEV_LABEL "(itf %d): can't set up page "
"mapping\n",dev->number);
- return error;
+ return -ENOMEM;
}
eni_dev->ioaddr = base;
eni_dev->base_diff = real_base - (unsigned long) base;