diff options
| author | Evgeny Kuznetsov <ext-eugeny.kuznetsov@nokia.com> | 2010-12-08 01:25:40 +0100 |
|---|---|---|
| committer | Tony Lindgren <tony@atomide.com> | 2010-12-08 01:25:40 +0100 |
| commit | b1cc4c55c69efed3ebbb2a13e4c77a2a1a4a6bc9 (patch) | |
| tree | 5aff7ab2977693735d0830f2cfe48e3fa944d969 | |
| parent | omap: Fix undefined reference to omap2_i2c_mux_pins (diff) | |
| download | linux-b1cc4c55c69efed3ebbb2a13e4c77a2a1a4a6bc9.tar.xz linux-b1cc4c55c69efed3ebbb2a13e4c77a2a1a4a6bc9.zip | |
omap: Ptr "isr_reg" tracked as NULL was dereferenced
Value of "isr_reg" pointer is depend on configuration and GPIO method.
Potentially it may have NULL value and it is dereferenced later
in code. Warning and exit from function are added in this case.
Signed-off-by: Evgeny Kuznetsov <EXT-Eugeny.Kuznetsov@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
| -rw-r--r-- | arch/arm/plat-omap/gpio.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c index c05c653d1674..e0e2fa725269 100644 --- a/arch/arm/plat-omap/gpio.c +++ b/arch/arm/plat-omap/gpio.c @@ -1318,6 +1318,10 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) if (bank->method == METHOD_GPIO_44XX) isr_reg = bank->base + OMAP4_GPIO_IRQSTATUS0; #endif + + if (WARN_ON(!isr_reg)) + goto exit; + while(1) { u32 isr_saved, level_mask = 0; u32 enabled; @@ -1377,6 +1381,7 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc) configured, we must unmask the bank interrupt only after handler(s) are executed in order to avoid spurious bank interrupt */ +exit: if (!unmasked) desc->chip->unmask(irq); |