summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>2011-06-14 11:24:39 +0200
committerPaul Mundt <lethal@linux-sh.org>2011-06-15 08:04:36 +0200
commitc6990b775d543c432f968808119d7fe33d506a71 (patch)
tree8926026d65b576245693e8063877824ae17f32b1
parentarkfb: use display information in info not in var for panning (diff)
downloadlinux-c6990b775d543c432f968808119d7fe33d506a71.tar.xz
linux-c6990b775d543c432f968808119d7fe33d506a71.zip
68328fb: use display information in info not in var for panning
We must not use any information in the passed var besides xoffset, yoffset and vmode as otherwise applications might abuse it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
-rw-r--r--drivers/video/68328fb.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/video/68328fb.c b/drivers/video/68328fb.c
index 75a39eab70c3..a425d65d5ba2 100644
--- a/drivers/video/68328fb.c
+++ b/drivers/video/68328fb.c
@@ -378,8 +378,8 @@ static int mc68x328fb_pan_display(struct fb_var_screeninfo *var,
|| var->xoffset)
return -EINVAL;
} else {
- if (var->xoffset + var->xres > info->var.xres_virtual ||
- var->yoffset + var->yres > info->var.yres_virtual)
+ if (var->xoffset + info->var.xres > info->var.xres_virtual ||
+ var->yoffset + info->var.yres > info->var.yres_virtual)
return -EINVAL;
}
info->var.xoffset = var->xoffset;