diff options
| author | Rob Herring <robh@kernel.org> | 2018-10-31 15:28:06 +0100 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2018-11-01 22:16:54 +0100 |
| commit | c961cb3be9064d1097ccc019390f8b5739daafc6 (patch) | |
| tree | 7cc7e9fb98472b595e7e3ab7b0de3fbcfc428af5 | |
| parent | dt-bindings: arm: Explain capacities-dmips-mhz calculations in example (diff) | |
| download | linux-c961cb3be9064d1097ccc019390f8b5739daafc6.tar.xz linux-c961cb3be9064d1097ccc019390f8b5739daafc6.zip | |
of: Fix cpu node iterator to not ignore disabled cpu nodes
In most cases, nodes with 'status = "disabled";' are treated as if the
node is not present though it is a common bug to forget to check that.
However, cpu nodes are different in that "disabled" simply means offline
and the OS can bring the CPU core online. Commit f1f207e43b8a ("of: Add
cpu node iterator for_each_of_cpu_node()") followed the common behavior
of ignoring disabled cpu nodes. This breaks some powerpc systems (at
least NXP P50XX/e5500). Fix this by dropping the status check.
Fixes: 651d44f9679c ("of: use for_each_of_cpu_node iterator")
Fixes: f1f207e43b8a ("of: Add cpu node iterator for_each_of_cpu_node()")
Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
Tested-by: Michael Ellerman <mpe@ellerman.id.au>
Cc: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>
| -rw-r--r-- | drivers/of/base.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/of/base.c b/drivers/of/base.c index cc62da278663..e47c5ce6cd58 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -776,8 +776,6 @@ struct device_node *of_get_next_cpu_node(struct device_node *prev) if (!(of_node_name_eq(next, "cpu") || (next->type && !of_node_cmp(next->type, "cpu")))) continue; - if (!__of_device_is_available(next)) - continue; if (of_node_get(next)) break; } |