diff options
| author | Arvind Yadav <arvind.yadav.cs@gmail.com> | 2017-11-29 17:17:11 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2017-12-01 14:05:45 +0100 |
| commit | d6e2c4ffdf67de68e0263630525d2b521132d66a (patch) | |
| tree | 8585b049e7db840875cf8870bef3aa8167647bb2 | |
| parent | Linux 4.15-rc1 (diff) | |
| download | linux-d6e2c4ffdf67de68e0263630525d2b521132d66a.tar.xz linux-d6e2c4ffdf67de68e0263630525d2b521132d66a.zip | |
ASoC: mt8173: Fix platform_get_irq's error checking
The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c index 8a643a35d3d4..c7f7f8add5d9 100644 --- a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c +++ b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c @@ -1083,7 +1083,7 @@ static int mt8173_afe_init_audio_clk(struct mtk_base_afe *afe) static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev) { int ret, i; - unsigned int irq_id; + int irq_id; struct mtk_base_afe *afe; struct mt8173_afe_private *afe_priv; struct resource *res; @@ -1105,9 +1105,9 @@ static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev) afe->dev = &pdev->dev; irq_id = platform_get_irq(pdev, 0); - if (!irq_id) { + if (irq_id <= 0) { dev_err(afe->dev, "np %s no irq\n", afe->dev->of_node->name); - return -ENXIO; + return irq_id < 0 ? irq_id : -ENXIO; } ret = devm_request_irq(afe->dev, irq_id, mt8173_afe_irq_handler, 0, "Afe_ISR_Handle", (void *)afe); |