diff options
| author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2011-06-14 11:24:49 +0200 |
|---|---|---|
| committer | Paul Mundt <lethal@linux-sh.org> | 2011-06-15 08:04:02 +0200 |
| commit | df2d79810930ead3112b4ebab86ea0f9229ccf70 (patch) | |
| tree | 0534004de037e92729c91d832366543e774108e7 | |
| parent | radeonfb: use display information in info not in var for panning (diff) | |
| download | linux-df2d79810930ead3112b4ebab86ea0f9229ccf70.tar.xz linux-df2d79810930ead3112b4ebab86ea0f9229ccf70.zip | |
hgafb: use display information in info not in var for panning
We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu>
Cc: Brent Cook <busterb@gmail.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
| -rw-r--r-- | drivers/video/hgafb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/video/hgafb.c b/drivers/video/hgafb.c index 4052718eefaa..4394389caf68 100644 --- a/drivers/video/hgafb.c +++ b/drivers/video/hgafb.c @@ -422,8 +422,8 @@ static int hgafb_pan_display(struct fb_var_screeninfo *var, var->xoffset) return -EINVAL; } else { - if (var->xoffset + var->xres > info->var.xres_virtual - || var->yoffset + var->yres > info->var.yres_virtual + if (var->xoffset + info->var.xres > info->var.xres_virtual + || var->yoffset + info->var.yres > info->var.yres_virtual || var->yoffset % 8) return -EINVAL; } |