diff options
| author | Bartosz Golaszewski <bgolaszewski@baylibre.com> | 2020-06-07 11:34:21 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-06-08 14:21:07 +0200 |
| commit | e680a4098f6404191e0e438a9758715b0bff6d7f (patch) | |
| tree | d5cfd8574e1b0d0ffaa02956e6db0405acc3efaa | |
| parent | regmap: fix alignment issue (diff) | |
| download | linux-e680a4098f6404191e0e438a9758715b0bff6d7f.tar.xz linux-e680a4098f6404191e0e438a9758715b0bff6d7f.zip | |
regmap: fix the kerneldoc for regmap_test_bits()
The kerneldoc comment for regmap_test_bits() says that it returns -1 on
regmap_read() failure. This is not true - it will propagate the error
code returned by regmap_read(). Fix it.
Fixes: aa2ff9dbaedd ("regmap: provide helpers for simple bit operations")
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Link: https://lore.kernel.org/r/20200607093421.22209-1-brgl@bgdev.pl
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/base/regmap/regmap.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 22d125da4a7d..183ec789c3fd 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -2936,8 +2936,9 @@ EXPORT_SYMBOL_GPL(regmap_update_bits_base); * @reg: Register to read from * @bits: Bits to test * - * Returns -1 if the underlying regmap_read() fails, 0 if at least one of the - * tested bits is not set and 1 if all tested bits are set. + * Returns 0 if at least one of the tested bits is not set, 1 if all tested + * bits are set and a negative error number if the underlying regmap_read() + * fails. */ int regmap_test_bits(struct regmap *map, unsigned int reg, unsigned int bits) { |