diff options
| author | Ani Sinha <anisinha@redhat.com> | 2023-07-05 15:44:07 +0200 |
|---|---|---|
| committer | Wei Liu <wei.liu@kernel.org> | 2023-07-24 01:19:30 +0200 |
| commit | ed0cf84e9cc42e6310961c87709621f1825c2bb8 (patch) | |
| tree | 0b8c2a6cf96af5164a691cb513ce6a0c3c0b5fda | |
| parent | x86/hyperv: fix a warning in mshyperv.h (diff) | |
| download | linux-ed0cf84e9cc42e6310961c87709621f1825c2bb8.tar.xz linux-ed0cf84e9cc42e6310961c87709621f1825c2bb8.zip | |
vmbus_testing: fix wrong python syntax for integer value comparison
It is incorrect in python to compare integer values using the "is" keyword.
The "is" keyword in python is used to compare references to two objects,
not their values. Newer version of python3 (version 3.8) throws a warning
when such incorrect comparison is made. For value comparison, "==" should
be used.
Fix this in the code and suppress the following warning:
/usr/sbin/vmbus_testing:167: SyntaxWarning: "is" with a literal. Did you mean "=="?
Signed-off-by: Ani Sinha <anisinha@redhat.com>
Link: https://lore.kernel.org/r/20230705134408.6302-1-anisinha@redhat.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
| -rwxr-xr-x | tools/hv/vmbus_testing | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/hv/vmbus_testing b/tools/hv/vmbus_testing index e7212903dd1d..4467979d8f69 100755 --- a/tools/hv/vmbus_testing +++ b/tools/hv/vmbus_testing @@ -164,7 +164,7 @@ def recursive_file_lookup(path, file_map): def get_all_devices_test_status(file_map): for device in file_map: - if (get_test_state(locate_state(device, file_map)) is 1): + if (get_test_state(locate_state(device, file_map)) == 1): print("Testing = ON for: {}" .format(device.split("/")[5])) else: @@ -203,7 +203,7 @@ def write_test_files(path, value): def set_test_state(state_path, state_value, quiet): write_test_files(state_path, state_value) - if (get_test_state(state_path) is 1): + if (get_test_state(state_path) == 1): if (not quiet): print("Testing = ON for device: {}" .format(state_path.split("/")[5])) |