diff options
| author | Hyeong-Jun Kim <hj514.kim@samsung.com> | 2021-10-27 06:16:00 +0200 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2021-10-28 00:32:29 +0200 |
| commit | 02d58cd253d7536c412993573fc6b3b4454960eb (patch) | |
| tree | f122c1f09c84804714e5f160b8cdc18c6a54b5f1 | |
| parent | f2fs: compress: fix overwrite may reduce compress ratio unproperly (diff) | |
| download | linux-02d58cd253d7536c412993573fc6b3b4454960eb.tar.xz linux-02d58cd253d7536c412993573fc6b3b4454960eb.zip | |
f2fs: compress: disallow disabling compress on non-empty compressed file
Compresse file and normal file has differ in i_addr addressing,
specifically addrs per inode/block. So, we will face data loss, if we
disable the compression flag on non-empty files. Therefore we should
disallow not only enabling but disabling the compression flag on
non-empty files.
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
Signed-off-by: Hyeong-Jun Kim <hj514.kim@samsung.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
| -rw-r--r-- | fs/f2fs/f2fs.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 5ba2d530c28a..c8c7d9e7dd7a 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4179,8 +4179,7 @@ static inline bool f2fs_disable_compressed_file(struct inode *inode) if (!f2fs_compressed_file(inode)) return true; - if (S_ISREG(inode->i_mode) && - (get_dirty_pages(inode) || atomic_read(&fi->i_compr_blocks))) + if (S_ISREG(inode->i_mode) && F2FS_HAS_BLOCKS(inode)) return false; fi->i_flags &= ~F2FS_COMPR_FL; |