diff options
| author | Simon Wood <simon@mungewell.org> | 2014-08-15 04:43:01 +0200 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2014-08-15 10:54:13 +0200 |
| commit | 29ff66571d38f01c5a5d3af871401b8a65323422 (patch) | |
| tree | f15a16911b64b63c5167d01193554a1fd356c429 | |
| parent | HID: rmi: print an error if F11 is not found instead of stopping the device (diff) | |
| download | linux-29ff66571d38f01c5a5d3af871401b8a65323422.tar.xz linux-29ff66571d38f01c5a5d3af871401b8a65323422.zip | |
HID: logitech: Prevent possibility of infinite loop when using /sys interface
If the device data is not accessible for some reason, returning 0 will cause the call to be
continuously called again as none of the string has been 'consumed'.
Signed-off-by: Simon Wood <simon@mungewell.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
| -rw-r--r-- | drivers/hid/hid-lg4ff.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c index cc2bd2022198..7835717bc020 100644 --- a/drivers/hid/hid-lg4ff.c +++ b/drivers/hid/hid-lg4ff.c @@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at drv_data = hid_get_drvdata(hid); if (!drv_data) { hid_err(hid, "Private driver data not found!\n"); - return 0; + return -EINVAL; } entry = drv_data->device_props; if (!entry) { hid_err(hid, "Device properties not found!\n"); - return 0; + return -EINVAL; } if (range == 0) |