summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTushar Behera <tushar.behera@linaro.org>2012-11-23 13:18:43 +0100
committerSamuel Ortiz <sameo@linux.intel.com>2012-11-30 11:51:30 +0100
commit4e1328be4d4e4967d54bf7ae3b0805ec53fc4f91 (patch)
tree195c32c1474fa064383d3c221c7082d0805f07b7
parentmfd: wm5102: Mark DSP memory regions as volatile (diff)
downloadlinux-4e1328be4d4e4967d54bf7ae3b0805ec53fc4f91.tar.xz
linux-4e1328be4d4e4967d54bf7ae3b0805ec53fc4f91.zip
mfd: ab8500-core: Fix invalid free of devm_ allocated data
The objects allocated by devm_* APIs are managed by devres and are freed when the device is detached. Hence there is no need to remove them explicitly in remove function. Signed-off-by: Tushar Behera <tushar.behera@linaro.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
-rw-r--r--drivers/mfd/ab8500-core.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/mfd/ab8500-core.c b/drivers/mfd/ab8500-core.c
index 5b8a4de4328b..660a09bf4564 100644
--- a/drivers/mfd/ab8500-core.c
+++ b/drivers/mfd/ab8500-core.c
@@ -1437,11 +1437,6 @@ static int __devexit ab8500_remove(struct platform_device *pdev)
sysfs_remove_group(&ab8500->dev->kobj, &ab8500_attr_group);
mfd_remove_devices(ab8500->dev);
- free_irq(ab8500->irq, ab8500);
-
- kfree(ab8500->oldmask);
- kfree(ab8500->mask);
- kfree(ab8500);
return 0;
}