diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2021-12-25 03:51:15 +0100 |
|---|---|---|
| committer | Petr Mladek <pmladek@suse.com> | 2022-01-04 13:57:19 +0100 |
| commit | 50a0f3f55e382b313e7cbebdf8ccf1593296e16f (patch) | |
| tree | ab01a2e48db5584faa5ef7e98ab31a5fc5b49bed | |
| parent | livepatch: Fix kobject refcount bug on klp_init_patch_early failure path (diff) | |
| download | linux-50a0f3f55e382b313e7cbebdf8ccf1593296e16f.tar.xz linux-50a0f3f55e382b313e7cbebdf8ccf1593296e16f.zip | |
livepatch: Fix missing unlock on error in klp_enable_patch()
Add missing unlock when try_module_get() fails in klp_enable_patch().
Fixes: 5ef3dd20555e8e8 ("livepatch: Fix kobject refcount bug on klp_init_patch_early failure path")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: David Vernet <void@manifault.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20211225025115.475348-1-yangyingliang@huawei.com
| -rw-r--r-- | kernel/livepatch/core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index 7d228cdb44c5..585494ec464f 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c @@ -1047,8 +1047,10 @@ int klp_enable_patch(struct klp_patch *patch) return -EINVAL; } - if (!try_module_get(patch->mod)) + if (!try_module_get(patch->mod)) { + mutex_unlock(&klp_mutex); return -ENODEV; + } klp_init_patch_early(patch); |