summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLam Thai <lamthai@arista.com>2022-08-25 00:59:00 +0200
committerAndrii Nakryiko <andrii@kernel.org>2022-08-25 20:43:08 +0200
commit7184aef9c0f7a81db8fd18d183ee42481d89bf35 (patch)
treee762daee9dd5f24fc9f9465a757c215861ce9825
parentMerge branch 'bpf: rstat: cgroup hierarchical' (diff)
downloadlinux-7184aef9c0f7a81db8fd18d183ee42481d89bf35.tar.xz
linux-7184aef9c0f7a81db8fd18d183ee42481d89bf35.zip
bpftool: Fix a wrong type cast in btf_dumper_int
When `data` points to a boolean value, casting it to `int *` is problematic and could lead to a wrong value being passed to `jsonw_bool`. Change the cast to `bool *` instead. Fixes: b12d6ec09730 ("bpf: btf: add btf print functionality") Signed-off-by: Lam Thai <lamthai@arista.com> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Reviewed-by: Quentin Monnet <quentin@isovalent.com> Acked-by: John Fastabend <john.fastabend@gmail.com> Link: https://lore.kernel.org/bpf/20220824225859.9038-1-lamthai@arista.com
-rw-r--r--tools/bpf/bpftool/btf_dumper.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/bpf/bpftool/btf_dumper.c b/tools/bpf/bpftool/btf_dumper.c
index 125798b0bc5d..19924b6ce796 100644
--- a/tools/bpf/bpftool/btf_dumper.c
+++ b/tools/bpf/bpftool/btf_dumper.c
@@ -452,7 +452,7 @@ static int btf_dumper_int(const struct btf_type *t, __u8 bit_offset,
*(char *)data);
break;
case BTF_INT_BOOL:
- jsonw_bool(jw, *(int *)data);
+ jsonw_bool(jw, *(bool *)data);
break;
default:
/* shouldn't happen */