diff options
| author | Oliver Upton <oupton@google.com> | 2022-03-22 19:35:38 +0100 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2022-04-06 11:39:39 +0200 |
| commit | 73b725c7a6c82eee10fa2d6752babefff795ca9a (patch) | |
| tree | d514bc21fe4ffb9b5ddf38c0f961c0e161b4dd78 | |
| parent | KVM: arm64: Actually prevent SMC64 SYSTEM_RESET2 from AArch32 (diff) | |
| download | linux-73b725c7a6c82eee10fa2d6752babefff795ca9a.tar.xz linux-73b725c7a6c82eee10fa2d6752babefff795ca9a.zip | |
KVM: arm64: Drop unneeded minor version check from PSCI v1.x handler
We already sanitize the guest's PSCI version when it is being written by
userspace, rejecting unsupported version numbers. Additionally, the
'minor' parameter to kvm_psci_1_x_call() is a constant known at compile
time for all callsites.
Though it is benign, the additional check against the
PSCI kvm_psci_1_x_call() is unnecessary and likely to be missed the next
time KVM raises its maximum PSCI version. Drop the check altogether and
rely on sanitization when the PSCI version is set by userspace.
No functional change intended.
Signed-off-by: Oliver Upton <oupton@google.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220322183538.2757758-4-oupton@google.com
| -rw-r--r-- | arch/arm64/kvm/psci.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/arch/arm64/kvm/psci.c b/arch/arm64/kvm/psci.c index faf403a72fdf..baac2b405f23 100644 --- a/arch/arm64/kvm/psci.c +++ b/arch/arm64/kvm/psci.c @@ -309,9 +309,6 @@ static int kvm_psci_1_x_call(struct kvm_vcpu *vcpu, u32 minor) unsigned long val; int ret = 1; - if (minor > 1) - return -EINVAL; - switch(psci_fn) { case PSCI_0_2_FN_PSCI_VERSION: val = minor == 0 ? KVM_ARM_PSCI_1_0 : KVM_ARM_PSCI_1_1; |