diff options
| author | Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> | 2007-03-26 02:38:42 +0200 |
|---|---|---|
| committer | Tony Luck <tony.luck@intel.com> | 2007-03-30 00:02:58 +0200 |
| commit | 8a3a0ee736b9a0150c9d894f2c6cc836a62125a1 (patch) | |
| tree | fb98ffc7f346bead619a31c08012234131bee7c9 | |
| parent | [PATCH] mm: fix xip issue with /dev/zero (diff) | |
| download | linux-8a3a0ee736b9a0150c9d894f2c6cc836a62125a1.tar.xz linux-8a3a0ee736b9a0150c9d894f2c6cc836a62125a1.zip | |
[IA64] Fix possible invalid memory access in ia64_setup_msi_irq()
The following 'if' statement in ia64_setup_msi_irq() always fails even
if create_irq() returns <0 value, because variable 'irq' is defined as
unsigned int. It would cause invalid memory access.
irq = create_irq();
if (irq < 0)
return irq;
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
| -rw-r--r-- | arch/ia64/kernel/msi_ia64.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/ia64/kernel/msi_ia64.c b/arch/ia64/kernel/msi_ia64.c index e7220900ea14..ebbeadfee42d 100644 --- a/arch/ia64/kernel/msi_ia64.c +++ b/arch/ia64/kernel/msi_ia64.c @@ -68,7 +68,7 @@ int ia64_setup_msi_irq(struct pci_dev *pdev, struct msi_desc *desc) { struct msi_msg msg; unsigned long dest_phys_id; - unsigned int irq, vector; + int irq, vector; irq = create_irq(); if (irq < 0) |