diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-01-26 11:26:54 +0100 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2021-01-26 15:29:57 +0100 |
| commit | a70aa7dc60099bbdcbd6faca42a915d80f31161e (patch) | |
| tree | c6adf0810a09023fd72b673f2cbcc09cebbb0ae8 | |
| parent | USB: cdc-acm: ignore Exar XR21V141X when serial driver is built (diff) | |
| download | linux-a70aa7dc60099bbdcbd6faca42a915d80f31161e.tar.xz linux-a70aa7dc60099bbdcbd6faca42a915d80f31161e.zip | |
USB: serial: mos7840: fix error code in mos7840_write()
This should return -ENOMEM instead of 0 if the kmalloc() fails.
Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
| -rw-r--r-- | drivers/usb/serial/mos7840.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index 23f91d658cb4..30c25ef0dacd 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -883,8 +883,10 @@ static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port, if (urb->transfer_buffer == NULL) { urb->transfer_buffer = kmalloc(URB_TRANSFER_BUFFER_SIZE, GFP_ATOMIC); - if (!urb->transfer_buffer) + if (!urb->transfer_buffer) { + bytes_sent = -ENOMEM; goto exit; + } } transfer_size = min(count, URB_TRANSFER_BUFFER_SIZE); |