diff options
| author | kbuild test robot <lkp@intel.com> | 2016-05-02 17:50:16 +0200 |
|---|---|---|
| committer | Shaohua Li <shli@fb.com> | 2016-05-04 21:39:35 +0200 |
| commit | bc47e84258be3e49c14be65a111f2117ecc986f6 (patch) | |
| tree | c333f0eeadfca8c8a3f63bed9e4debda9cf68770 | |
| parent | md-cluster/bitmap: unplug bitmap to sync dirty pages to disk (diff) | |
| download | linux-bc47e84258be3e49c14be65a111f2117ecc986f6.tar.xz linux-bc47e84258be3e49c14be65a111f2117ecc986f6.zip | |
md-cluster: fix ifnullfree.cocci warnings
drivers/md/bitmap.c:2049:6-11: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Acked-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Shaohua Li <shli@fb.com>
| -rw-r--r-- | drivers/md/bitmap.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 4a05bacd6601..ad5a85847004 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c @@ -2076,8 +2076,7 @@ int bitmap_resize(struct bitmap *bitmap, sector_t blocks, /* deallocate the page memory */ for (k = 0; k < page; k++) { - if (new_bp[k].map) - kfree(new_bp[k].map); + kfree(new_bp[k].map); } /* restore some fields from old_counts */ |