summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJi Sheng Teoh <jisheng.teoh@starfivetech.com>2024-01-30 06:51:18 +0100
committerWim Van Sebroeck <wim@linux-watchdog.org>2024-03-03 14:17:29 +0100
commitd869d6352a5c2b13e76c19ba8f7243f422cf3fd0 (patch)
tree050552fe9450606e496c2ad3e9183c6151962cd8
parentwatchdog: starfive: Check pm_runtime_enabled() before decrementing usage counter (diff)
downloadlinux-d869d6352a5c2b13e76c19ba8f7243f422cf3fd0.tar.xz
linux-d869d6352a5c2b13e76c19ba8f7243f422cf3fd0.zip
watchdog: starfive: check watchdog status before enabling in system resume
System resume will start and enable watchdog regardless of whether the watchdog is enabled/disabled during a system suspend. Add a check to the watchdog status and only start and enable the watchdog if the watchdog status is running/active. Signed-off-by: Sia Jee Heng <jeeheng.sia@starfivetech.com> Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20240130055118.1917086-1-jisheng.teoh@starfivetech.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
-rw-r--r--drivers/watchdog/starfive-wdt.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/watchdog/starfive-wdt.c b/drivers/watchdog/starfive-wdt.c
index df68ae4acbd7..b4b059883618 100644
--- a/drivers/watchdog/starfive-wdt.c
+++ b/drivers/watchdog/starfive-wdt.c
@@ -559,7 +559,10 @@ static int starfive_wdt_resume(struct device *dev)
starfive_wdt_set_reload_count(wdt, wdt->reload);
starfive_wdt_lock(wdt);
- return starfive_wdt_start(wdt);
+ if (watchdog_active(&wdt->wdd))
+ return starfive_wdt_start(wdt);
+
+ return 0;
}
static int starfive_wdt_runtime_suspend(struct device *dev)