summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2023-09-09 18:45:37 +0200
committerAndrew Morton <akpm@linux-foundation.org>2023-10-04 19:41:57 +0200
commite5ecf29c507830f192d3eb255662ad9ba219c442 (patch)
treef5b677554be5c5fc55acad7c72741ccaa0af6b77
parentfs/proc: do_task_stat: use __for_each_thread() (diff)
downloadlinux-e5ecf29c507830f192d3eb255662ad9ba219c442.tar.xz
linux-e5ecf29c507830f192d3eb255662ad9ba219c442.zip
signal: complete_signal: use __for_each_thread()
do/while_each_thread should be avoided when possible. Link: https://lkml.kernel.org/r/20230909164537.GA11633@redhat.com Signed-off-by: Oleg Nesterov <oleg@redhat.com> Cc: Eric W. Biederman <ebiederm@xmission.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-rw-r--r--kernel/signal.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/kernel/signal.c b/kernel/signal.c
index fc276fc07d87..ccfc3ded5672 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1058,12 +1058,11 @@ static void complete_signal(int sig, struct task_struct *p, enum pid_type type)
signal->flags = SIGNAL_GROUP_EXIT;
signal->group_exit_code = sig;
signal->group_stop_count = 0;
- t = p;
- do {
+ __for_each_thread(signal, t) {
task_clear_jobctl_pending(t, JOBCTL_PENDING_MASK);
sigaddset(&t->pending.signal, SIGKILL);
signal_wake_up(t, 1);
- } while_each_thread(p, t);
+ }
return;
}
}