diff options
| author | Stephen Boyd <sboyd@kernel.org> | 2019-07-31 21:35:15 +0200 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2019-08-16 19:20:07 +0200 |
| commit | f6c90df8e7e33c3dc33d4d7471bc42c232b0510e (patch) | |
| tree | 82023120e565ab850a5204fde6e634cb39f7ec8c | |
| parent | clk: socfpga: Don't reference clk_init_data after registration (diff) | |
| download | linux-f6c90df8e7e33c3dc33d4d7471bc42c232b0510e.tar.xz linux-f6c90df8e7e33c3dc33d4d7471bc42c232b0510e.zip | |
clk: sprd: Don't reference clk_init_data after registration
A future patch is going to change semantics of clk_register() so that
clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid
referencing this member here so that we don't run into NULL pointer
exceptions.
Cc: Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: Baolin Wang <baolin.wang@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lkml.kernel.org/r/20190731193517.237136-8-sboyd@kernel.org
Acked-by: Baolin Wang <baolin.wang@linaro.org>
Acked-by: Chunyan Zhang <zhang.chunyan@linaro.org>
| -rw-r--r-- | drivers/clk/sprd/common.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c index a5bdca1de5d0..9d56eac43832 100644 --- a/drivers/clk/sprd/common.c +++ b/drivers/clk/sprd/common.c @@ -76,16 +76,17 @@ int sprd_clk_probe(struct device *dev, struct clk_hw_onecell_data *clkhw) struct clk_hw *hw; for (i = 0; i < clkhw->num; i++) { + const char *name; hw = clkhw->hws[i]; - if (!hw) continue; + name = hw->init->name; ret = devm_clk_hw_register(dev, hw); if (ret) { dev_err(dev, "Couldn't register clock %d - %s\n", - i, hw->init->name); + i, name); return ret; } } |