diff options
| author | Kees Cook <keescook@chromium.org> | 2018-11-01 22:03:07 +0100 |
|---|---|---|
| committer | Kees Cook <keescook@chromium.org> | 2018-12-04 01:52:35 +0100 |
| commit | 0eed84ffb094bbddfb4b9378ef0a2eccf4dda99c (patch) | |
| tree | 67a4d68cf26f25dde588702cb4ed4f905436e91b | |
| parent | pstore/ram: Add kern-doc for struct persistent_ram_zone (diff) | |
| download | linux-0eed84ffb094bbddfb4b9378ef0a2eccf4dda99c.tar.xz linux-0eed84ffb094bbddfb4b9378ef0a2eccf4dda99c.zip | |
pstore: Improve and update some comments and status output
This improves and updates some comments:
- dump handler comment out of sync from calling convention
- fix kern-doc typo
and improves status output:
- reminder that only kernel crash dumps are compressed
- do not be silent about ECC infrastructure failures
Signed-off-by: Kees Cook <keescook@chromium.org>
| -rw-r--r-- | fs/pstore/platform.c | 7 | ||||
| -rw-r--r-- | fs/pstore/ram_core.c | 4 | ||||
| -rw-r--r-- | include/linux/pstore.h | 2 |
3 files changed, 7 insertions, 6 deletions
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index a75756c48e10..32340e7dd6a5 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -304,7 +304,7 @@ static void allocate_buf_for_compression(void) big_oops_buf_sz = size; big_oops_buf = buf; - pr_info("Using compression: %s\n", zbackend->name); + pr_info("Using crash dump compression: %s\n", zbackend->name); } static void free_buf_for_compression(void) @@ -354,9 +354,8 @@ void pstore_record_init(struct pstore_record *record, } /* - * callback from kmsg_dump. (s2,l2) has the most recently - * written bytes, older bytes are in (s1,l1). Save as much - * as we can from the end of the buffer. + * callback from kmsg_dump. Save as much as we can (up to kmsg_bytes) from the + * end of the buffer. */ static void pstore_dump(struct kmsg_dumper *dumper, enum kmsg_dump_reason reason) diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c index 3e9e3ba4fb07..e6375439c5ac 100644 --- a/fs/pstore/ram_core.c +++ b/fs/pstore/ram_core.c @@ -503,8 +503,10 @@ static int persistent_ram_post_init(struct persistent_ram_zone *prz, u32 sig, bool zap = !!(prz->flags & PRZ_FLAG_ZAP_OLD); ret = persistent_ram_init_ecc(prz, ecc_info); - if (ret) + if (ret) { + pr_warn("ECC failed %s\n", prz->label); return ret; + } sig ^= PERSISTENT_RAM_SIG; diff --git a/include/linux/pstore.h b/include/linux/pstore.h index 30fcec375a3a..81669aa80027 100644 --- a/include/linux/pstore.h +++ b/include/linux/pstore.h @@ -85,7 +85,7 @@ struct pstore_record { /** * struct pstore_info - backend pstore driver structure * - * @owner: module which is repsonsible for this backend driver + * @owner: module which is responsible for this backend driver * @name: name of the backend driver * * @buf_lock: spinlock to serialize access to @buf |