diff options
| author | Mike Snitzer <snitzer@redhat.com> | 2011-03-24 14:54:31 +0100 |
|---|---|---|
| committer | Alasdair G Kergon <agk@redhat.com> | 2011-03-24 14:54:31 +0100 |
| commit | 19040c0bc8efcb767221d8ef7bb9c32ff0586179 (patch) | |
| tree | 49df397ce008ecc7f2e19caadb86c1c7c7fbcbf3 | |
| parent | dm ioctl: add flag to wipe buffers for secure data (diff) | |
| download | linux-19040c0bc8efcb767221d8ef7bb9c32ff0586179.tar.xz linux-19040c0bc8efcb767221d8ef7bb9c32ff0586179.zip | |
dm mpath: fail message ioctl if specified path is not valid
Fail the reinstate_path and fail_path message ioctl if the specified
path is not valid.
The message ioctl would succeed for the 'reinistate_path' and
'fail_path' messages even if action was not taken because the
specified device was not a valid path of the multipath device.
Before, when /dev/vdb is not a path of mpathb:
$ dmsetup message mpathb 0 reinstate_path /dev/vdb
$ echo $?
0
After:
$ dmsetup message mpathb 0 reinstate_path /dev/vdb
device-mapper: message ioctl failed: Invalid argument
Command failed
$ echo $?
1
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
| -rw-r--r-- | drivers/md/dm-mpath.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index 4b0b63c290a6..52f0de394632 100644 --- a/drivers/md/dm-mpath.c +++ b/drivers/md/dm-mpath.c @@ -1065,7 +1065,7 @@ out: static int action_dev(struct multipath *m, struct dm_dev *dev, action_fn action) { - int r = 0; + int r = -EINVAL; struct pgpath *pgpath; struct priority_group *pg; @@ -1669,7 +1669,7 @@ out: *---------------------------------------------------------------*/ static struct target_type multipath_target = { .name = "multipath", - .version = {1, 2, 0}, + .version = {1, 3, 0}, .module = THIS_MODULE, .ctr = multipath_ctr, .dtr = multipath_dtr, |