diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-07-08 11:49:21 +0200 |
|---|---|---|
| committer | Sam Ravnborg <sam@ravnborg.org> | 2022-07-09 10:46:01 +0200 |
| commit | 1fd452c403ca2cd9dcbd8465f9f72be52e15ac1a (patch) | |
| tree | 55f8a75ca0a92c215254cfb84c7a959200046262 | |
| parent | drm/panel: simple: Make panel_simple_remove() return void (diff) | |
| download | linux-1fd452c403ca2cd9dcbd8465f9f72be52e15ac1a.tar.xz linux-1fd452c403ca2cd9dcbd8465f9f72be52e15ac1a.zip | |
drm/panel-novatek-nt35510: Emit an error message if power off fails
Returning an error code from a mipi_dsi remove callback fails, this is
silently ignored. (mipi_dsi_drv_remove() propagates the return value to
device_remove() which ignores it.) So emit an error code in the driver
remove function and return 0.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220708094922.1408248-3-u.kleine-koenig@pengutronix.de
| -rw-r--r-- | drivers/gpu/drm/panel/panel-novatek-nt35510.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35510.c b/drivers/gpu/drm/panel/panel-novatek-nt35510.c index 40ea41b0a5dd..1b3e0154bfb8 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt35510.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt35510.c @@ -974,9 +974,12 @@ static int nt35510_remove(struct mipi_dsi_device *dsi) mipi_dsi_detach(dsi); /* Power off */ ret = nt35510_power_off(nt); + if (ret) + dev_err(&dsi->dev, "Failed to power off\n"); + drm_panel_remove(&nt->panel); - return ret; + return 0; } /* |