summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaulo Alcantara <pc@manguebit.com>2024-04-02 21:33:59 +0200
committerSteve French <stfrench@microsoft.com>2024-04-03 21:43:45 +0200
commit22863485a4626ec6ecf297f4cc0aef709bc862e4 (patch)
tree4bcc4767685bd42b5807c54aaf0c862136e5d97c
parentsmb: client: fix potential UAF in smb2_is_valid_lease_break() (diff)
downloadlinux-22863485a4626ec6ecf297f4cc0aef709bc862e4.tar.xz
linux-22863485a4626ec6ecf297f4cc0aef709bc862e4.zip
smb: client: fix potential UAF in smb2_is_valid_oplock_break()
Skip sessions that are being teared down (status == SES_EXITING) to avoid UAF. Cc: stable@vger.kernel.org Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com> Signed-off-by: Steve French <stfrench@microsoft.com>
-rw-r--r--fs/smb/client/smb2misc.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/smb/client/smb2misc.c b/fs/smb/client/smb2misc.c
index ed6d033dce96..cc72be5a93a9 100644
--- a/fs/smb/client/smb2misc.c
+++ b/fs/smb/client/smb2misc.c
@@ -699,6 +699,8 @@ smb2_is_valid_oplock_break(char *buffer, struct TCP_Server_Info *server)
/* look up tcon based on tid & uid */
spin_lock(&cifs_tcp_ses_lock);
list_for_each_entry(ses, &pserver->smb_ses_list, smb_ses_list) {
+ if (cifs_ses_exiting(ses))
+ continue;
list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
spin_lock(&tcon->open_file_lock);