diff options
| author | Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> | 2021-05-28 14:41:54 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-05-29 00:05:55 +0200 |
| commit | 41a6bf50ee04a604f84ba8989055781d68061ed6 (patch) | |
| tree | 1b50a7c6ff3bf2d75d8a41bfa677bb118d3f6d89 | |
| parent | nfc: mrvl: mark OF device ID tables as maybe unused (diff) | |
| download | linux-41a6bf50ee04a604f84ba8989055781d68061ed6.tar.xz linux-41a6bf50ee04a604f84ba8989055781d68061ed6.zip | |
nfc: mrvl: skip impossible NCI_MAX_PAYLOAD_SIZE check
The nci_ctrl_hdr.plen field us u8, so checkign if it is bigger than
NCI_MAX_PAYLOAD_SIZE does not make any sense. Fix warning reported by
Smatch:
drivers/nfc/nfcmrvl/i2c.c:52 nfcmrvl_i2c_read() warn:
impossible condition '(nci_hdr.plen > 255) => (0-255 > 255)'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210528124200.79655-6-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/nfc/nfcmrvl/i2c.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/nfc/nfcmrvl/i2c.c b/drivers/nfc/nfcmrvl/i2c.c index bafd9b500b2c..3c9bbee98237 100644 --- a/drivers/nfc/nfcmrvl/i2c.c +++ b/drivers/nfc/nfcmrvl/i2c.c @@ -49,11 +49,6 @@ static int nfcmrvl_i2c_read(struct nfcmrvl_i2c_drv_data *drv_data, return -EBADMSG; } - if (nci_hdr.plen > NCI_MAX_PAYLOAD_SIZE) { - nfc_err(&drv_data->i2c->dev, "invalid packet payload size\n"); - return -EBADMSG; - } - *skb = nci_skb_alloc(drv_data->priv->ndev, nci_hdr.plen + NCI_CTRL_HDR_SIZE, GFP_KERNEL); if (!*skb) |