diff options
author | Alexey Khoroshilov <khoroshilov@ispras.ru> | 2015-07-19 18:13:28 +0200 |
---|---|---|
committer | Felipe Balbi <balbi@ti.com> | 2015-07-20 19:57:46 +0200 |
commit | 53e20f2eb161fbe9eea28b54dccc870cec94eca2 (patch) | |
tree | 9f076161b5f54b4f871f28174260e70077a31242 | |
parent | usb: ulpi: ulpi_init should be executed in subsys_initcall (diff) | |
download | linux-53e20f2eb161fbe9eea28b54dccc870cec94eca2.tar.xz linux-53e20f2eb161fbe9eea28b54dccc870cec94eca2.zip |
usb: gadget: mv_udc_core: fix phy_regs I/O memory leak
There was an omission in transition to devm_xxx resource handling.
iounmap(udc->phy_regs) were removed, but ioremap() was left
without devm_.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Fixes: 3517c31a8ece6 ("usb: gadget: mv_udc: use devm_xxx for probe")
Signed-off-by: Felipe Balbi <balbi@ti.com>
-rw-r--r-- | drivers/usb/gadget/udc/mv_udc_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index d32160d6463f..5da37c957b53 100644 --- a/drivers/usb/gadget/udc/mv_udc_core.c +++ b/drivers/usb/gadget/udc/mv_udc_core.c @@ -2167,7 +2167,7 @@ static int mv_udc_probe(struct platform_device *pdev) return -ENODEV; } - udc->phy_regs = ioremap(r->start, resource_size(r)); + udc->phy_regs = devm_ioremap(&pdev->dev, r->start, resource_size(r)); if (udc->phy_regs == NULL) { dev_err(&pdev->dev, "failed to map phy I/O memory\n"); return -EBUSY; |