diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-04-07 10:01:53 +0200 |
|---|---|---|
| committer | Thierry Reding <thierry.reding@gmail.com> | 2021-04-09 15:21:18 +0200 |
| commit | 64d7d074acd52e1bdff621f2cb86c0aae9bcef80 (patch) | |
| tree | cfa2994803adc62ea28541475e0d8f04039d0df4 | |
| parent | pwm: sti: Free resources only after pwmchip_remove() (diff) | |
| download | linux-64d7d074acd52e1bdff621f2cb86c0aae9bcef80.tar.xz linux-64d7d074acd52e1bdff621f2cb86c0aae9bcef80.zip | |
pwm: lpss: Don't modify HW state in .remove callback
A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.
So drop the hardware modification from the .remove() callback.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
| -rw-r--r-- | drivers/pwm/pwm-lpss.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c index 9ea6a176cbe5..58b4031524af 100644 --- a/drivers/pwm/pwm-lpss.c +++ b/drivers/pwm/pwm-lpss.c @@ -254,12 +254,6 @@ EXPORT_SYMBOL_GPL(pwm_lpss_probe); int pwm_lpss_remove(struct pwm_lpss_chip *lpwm) { - int i; - - for (i = 0; i < lpwm->info->npwm; i++) { - if (pwm_is_enabled(&lpwm->chip.pwms[i])) - pm_runtime_put(lpwm->chip.dev); - } return pwmchip_remove(&lpwm->chip); } EXPORT_SYMBOL_GPL(pwm_lpss_remove); |