summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>2016-06-06 23:23:32 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-06-08 07:18:39 +0200
commit7c348f1cfb6d8c6911fcb6d13b4c267a8bc93856 (patch)
tree9f56caf6b7dfe6b728dd1bf825857c7f21f7bd38
parentusb: microtek: Use "foo *bar" instead of "foo * bar". (diff)
downloadlinux-7c348f1cfb6d8c6911fcb6d13b4c267a8bc93856.tar.xz
linux-7c348f1cfb6d8c6911fcb6d13b4c267a8bc93856.zip
usb: usbip: remove null check
The only caller of get_gadget_descs() has already dereferenced udc before calling this function, so udc can not be NULL at this point of the code and hence no use of checking it. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/usbip/vudc_sysfs.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c
index 99397fa1e3f0..0f98f2c7475f 100644
--- a/drivers/usb/usbip/vudc_sysfs.c
+++ b/drivers/usb/usbip/vudc_sysfs.c
@@ -40,7 +40,7 @@ int get_gadget_descs(struct vudc *udc)
struct usb_ctrlrequest req;
int ret;
- if (!udc || !udc->driver || !udc->pullup)
+ if (!udc->driver || !udc->pullup)
return -EINVAL;
req.bRequestType = USB_DIR_IN | USB_TYPE_STANDARD | USB_RECIP_DEVICE;