diff options
| author | Roger Quadros <rogerq@ti.com> | 2012-11-26 14:17:32 +0100 |
|---|---|---|
| committer | Roger Quadros <rogerq@ti.com> | 2013-02-13 12:22:41 +0100 |
| commit | 8bdbd1549479840293e46bf0f84d7174e77b7b5e (patch) | |
| tree | 4f08c2410d622ede3d2d7f5e7654546b78770845 | |
| parent | mfd: omap-usb-tll: introduce and use mode_needs_tll() (diff) | |
| download | linux-8bdbd1549479840293e46bf0f84d7174e77b7b5e.tar.xz linux-8bdbd1549479840293e46bf0f84d7174e77b7b5e.zip | |
mfd: omap-usb-tll: Check for missing platform data in probe
No need to check for missing platform data in runtime_suspend/resume
as it makes more sense to do it in the probe function.
Signed-off-by: Roger Quadros <rogerq@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
| -rw-r--r-- | drivers/mfd/omap-usb-tll.c | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c index af67b96ded0f..3dbbfea515ad 100644 --- a/drivers/mfd/omap-usb-tll.c +++ b/drivers/mfd/omap-usb-tll.c @@ -225,6 +225,11 @@ static int usbtll_omap_probe(struct platform_device *pdev) return -ENOMEM; } + if (!pdata) { + dev_err(dev, "Platform data missing\n"); + return -ENODEV; + } + spin_lock_init(&tll->lock); tll->pdata = pdata; @@ -368,11 +373,6 @@ static int usbtll_runtime_resume(struct device *dev) dev_dbg(dev, "usbtll_runtime_resume\n"); - if (!pdata) { - dev_dbg(dev, "missing platform_data\n"); - return -ENODEV; - } - spin_lock_irqsave(&tll->lock, flags); for (i = 0; i < tll->nch; i++) { @@ -404,11 +404,6 @@ static int usbtll_runtime_suspend(struct device *dev) dev_dbg(dev, "usbtll_runtime_suspend\n"); - if (!pdata) { - dev_dbg(dev, "missing platform_data\n"); - return -ENODEV; - } - spin_lock_irqsave(&tll->lock, flags); for (i = 0; i < tll->nch; i++) { |