diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2024-03-10 08:52:28 +0100 |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2024-04-30 14:19:03 +0200 |
| commit | 919e3ece7f5aaf7b5f3c54538d5303b6eeeb053b (patch) | |
| tree | 9b726a5cecc3daaef7365dbf0fbc3cadb8c6206d | |
| parent | um: rtc: Convert to platform remove callback returning void (diff) | |
| download | linux-919e3ece7f5aaf7b5f3c54538d5303b6eeeb053b.tar.xz linux-919e3ece7f5aaf7b5f3c54538d5303b6eeeb053b.zip | |
um: virtio_uml: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Richard Weinberger <richard@nod.at>
| -rw-r--r-- | arch/um/drivers/virtio_uml.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/arch/um/drivers/virtio_uml.c b/arch/um/drivers/virtio_uml.c index 8adca2000e51..77faa2cf3a13 100644 --- a/arch/um/drivers/virtio_uml.c +++ b/arch/um/drivers/virtio_uml.c @@ -1241,12 +1241,11 @@ error_free: return rc; } -static int virtio_uml_remove(struct platform_device *pdev) +static void virtio_uml_remove(struct platform_device *pdev) { struct virtio_uml_device *vu_dev = platform_get_drvdata(pdev); unregister_virtio_device(&vu_dev->vdev); - return 0; } /* Command line device list */ @@ -1445,7 +1444,7 @@ static int virtio_uml_resume(struct platform_device *pdev) static struct platform_driver virtio_uml_driver = { .probe = virtio_uml_probe, - .remove = virtio_uml_remove, + .remove_new = virtio_uml_remove, .driver = { .name = "virtio-uml", .of_match_table = virtio_uml_match, |