diff options
| author | Huai-Yuan Liu <qq810974084@gmail.com> | 2024-04-07 08:30:53 +0200 |
|---|---|---|
| committer | Liviu Dudau <liviu.dudau@arm.com> | 2024-04-12 13:57:59 +0200 |
| commit | a1f95aede6285dba6dd036d907196f35ae3a11ea (patch) | |
| tree | 2eede0fd00c3e6df39f8e860b128469e2d8568a0 | |
| parent | drm/i915: Add SIZE_HINTS property for cursors (diff) | |
| download | linux-a1f95aede6285dba6dd036d907196f35ae3a11ea.tar.xz linux-a1f95aede6285dba6dd036d907196f35ae3a11ea.zip | |
drm/arm/malidp: fix a possible null pointer dereference
In malidp_mw_connector_reset, new memory is allocated with kzalloc, but
no check is performed. In order to prevent null pointer dereferencing,
ensure that mw_state is checked before calling
__drm_atomic_helper_connector_reset.
Fixes: 8cbc5caf36ef ("drm: mali-dp: Add writeback connector")
Signed-off-by: Huai-Yuan Liu <qq810974084@gmail.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240407063053.5481-1-qq810974084@gmail.com
| -rw-r--r-- | drivers/gpu/drm/arm/malidp_mw.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_mw.c index 626709bec6f5..2577f0cef8fc 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -72,7 +72,10 @@ static void malidp_mw_connector_reset(struct drm_connector *connector) __drm_atomic_helper_connector_destroy_state(connector->state); kfree(connector->state); - __drm_atomic_helper_connector_reset(connector, &mw_state->base); + connector->state = NULL; + + if (mw_state) + __drm_atomic_helper_connector_reset(connector, &mw_state->base); } static enum drm_connector_status |