summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason A. Donenfeld <Jason@zx2c4.com>2017-06-08 04:44:54 +0200
committerTheodore Ts'o <tytso@mit.edu>2017-06-20 04:06:28 +0200
commitae5b806a3d3c23d9d3b57aecbe687a0bd82ab086 (patch)
treeb5d8eb3b6f2d986cb3733ad19561a63961de0f93
parentiscsi: ensure RNG is seeded before use (diff)
downloadlinux-ae5b806a3d3c23d9d3b57aecbe687a0bd82ab086.tar.xz
linux-ae5b806a3d3c23d9d3b57aecbe687a0bd82ab086.zip
ceph: ensure RNG is seeded before using
Ceph uses the RNG for various nonce generations, and it shouldn't accept using bad randomness. So, we wait for the RNG to be properly seeded. We do this by calling wait_for_random_bytes() in a function that is certainly called in process context, early on, so that all subsequent calls to get_random_bytes are necessarily acceptable. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Cc: Ilya Dryomov <idryomov@gmail.com> Cc: "Yan, Zheng" <zyan@redhat.com> Cc: Sage Weil <sage@redhat.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
-rw-r--r--net/ceph/ceph_common.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/net/ceph/ceph_common.c b/net/ceph/ceph_common.c
index 4fd02831beed..26ab58665f77 100644
--- a/net/ceph/ceph_common.c
+++ b/net/ceph/ceph_common.c
@@ -611,7 +611,11 @@ struct ceph_client *ceph_create_client(struct ceph_options *opt, void *private)
{
struct ceph_client *client;
struct ceph_entity_addr *myaddr = NULL;
- int err = -ENOMEM;
+ int err;
+
+ err = wait_for_random_bytes();
+ if (err < 0)
+ return ERR_PTR(err);
client = kzalloc(sizeof(*client), GFP_KERNEL);
if (client == NULL)