diff options
| author | Markus Stockhausen <stockhausen@collogia.de> | 2014-08-23 12:19:27 +0200 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2014-10-14 04:08:28 +0200 |
| commit | b8e6a15a1af9b1c203002e7768e60136c4e0e5c6 (patch) | |
| tree | 551414765bf408c6e4c1e26e82597724973eda9f | |
| parent | md/raid10: another memory leak due to reshape. (diff) | |
| download | linux-b8e6a15a1af9b1c203002e7768e60136c4e0e5c6.tar.xz linux-b8e6a15a1af9b1c203002e7768e60136c4e0e5c6.zip | |
md/raid5: fix init_stripe() inconsistencies
raid5: fix init_stripe() inconsistencies
1) remove_hash() is not necessary. We will only be called right after
get_free_stripe(). There we have already a call to remove_hash().
2) Tracing prints out the sector of the freed stripe and not the sector
that we want to initialize.
Signed-off-by: NeilBrown <neilb@suse.de>
| -rw-r--r-- | drivers/md/raid5.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index b177cc4c111e..741134d429a4 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -531,9 +531,7 @@ static void init_stripe(struct stripe_head *sh, sector_t sector, int previous) BUG_ON(stripe_operations_active(sh)); pr_debug("init_stripe called, stripe %llu\n", - (unsigned long long)sh->sector); - - remove_hash(sh); + (unsigned long long)sector); retry: seq = read_seqcount_begin(&conf->gen_lock); sh->generation = conf->generation - previous; |