summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDarrick J. Wong <darrick.wong@oracle.com>2020-11-03 02:14:07 +0100
committerDarrick J. Wong <darrick.wong@oracle.com>2020-11-04 17:52:47 +0100
commitc1f6b1ac00756a7108e5fcb849a2f8230c0b62a5 (patch)
treee0d6176443182b5a004beb6fdbc797278e3f9a51
parentxfs: fix missing CoW blocks writeback conversion retry (diff)
downloadlinux-c1f6b1ac00756a7108e5fcb849a2f8230c0b62a5.tar.xz
linux-c1f6b1ac00756a7108e5fcb849a2f8230c0b62a5.zip
xfs: fix scrub flagging rtinherit even if there is no rt device
The kernel has always allowed directories to have the rtinherit flag set, even if there is no rt device, so this check is wrong. Fixes: 80e4e1268802 ("xfs: scrub inodes") Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
-rw-r--r--fs/xfs/scrub/inode.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/xfs/scrub/inode.c b/fs/xfs/scrub/inode.c
index 3aa85b64de36..bb25ff1b770d 100644
--- a/fs/xfs/scrub/inode.c
+++ b/fs/xfs/scrub/inode.c
@@ -121,8 +121,7 @@ xchk_inode_flags(
goto bad;
/* rt flags require rt device */
- if ((flags & (XFS_DIFLAG_REALTIME | XFS_DIFLAG_RTINHERIT)) &&
- !mp->m_rtdev_targp)
+ if ((flags & XFS_DIFLAG_REALTIME) && !mp->m_rtdev_targp)
goto bad;
/* new rt bitmap flag only valid for rbmino */