diff options
| author | Masahiro Yamada <masahiroy@kernel.org> | 2022-02-08 07:26:18 +0100 |
|---|---|---|
| committer | Masahiro Yamada <masahiroy@kernel.org> | 2022-02-10 01:17:26 +0100 |
| commit | d23a0c3718222a42430fd56359478a6fc7675070 (patch) | |
| tree | 8795d50d15a90ce4fb5712b6851c5dd9a020a98d | |
| parent | Makefile.extrawarn: Move -Wunaligned-access to W=1 (diff) | |
| download | linux-d23a0c3718222a42430fd56359478a6fc7675070.tar.xz linux-d23a0c3718222a42430fd56359478a6fc7675070.zip | |
kconfig: fix missing fclose() on error paths
The file is not closed when ferror() fails.
Fixes: 00d674cb3536 ("kconfig: refactor conf_write_dep()")
Fixes: 57ddd07c4560 ("kconfig: refactor conf_write_autoconf()")
Reported-by: Ryan Cai <ycaibb@gmail.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
| -rw-r--r-- | scripts/kconfig/confdata.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c index 59717be31210..16897cb8cefd 100644 --- a/scripts/kconfig/confdata.c +++ b/scripts/kconfig/confdata.c @@ -979,10 +979,10 @@ static int conf_write_autoconf_cmd(const char *autoconf_name) fprintf(out, "\n$(deps_config): ;\n"); - if (ferror(out)) /* error check for all fprintf() calls */ - return -1; - + ret = ferror(out); /* error check for all fprintf() calls */ fclose(out); + if (ret) + return -1; if (rename(tmp, name)) { perror("rename"); @@ -1093,10 +1093,10 @@ static int __conf_write_autoconf(const char *filename, print_symbol(file, sym); /* check possible errors in conf_write_heading() and print_symbol() */ - if (ferror(file)) - return -1; - + ret = ferror(file); fclose(file); + if (ret) + return -1; if (rename(tmp, filename)) { perror("rename"); |