diff options
| author | Thomas Graf <tgraf@suug.ch> | 2015-04-22 09:41:45 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-04-22 20:17:22 +0200 |
| commit | e2307ed6cbe71c74e291681aaa7e92ab98bc3177 (patch) | |
| tree | 85280146bb297aaf40b4f921f0a1983fe01fe80d | |
| parent | tcp: fix possible deadlock in tcp_send_fin() (diff) | |
| download | linux-e2307ed6cbe71c74e291681aaa7e92ab98bc3177.tar.xz linux-e2307ed6cbe71c74e291681aaa7e92ab98bc3177.zip | |
rhashtable: Schedule async resize when sync realloc fails
When rhashtable_insert_rehash() fails with ENOMEM, this indicates that
we can't allocate the necessary memory in the current context but the
limits as set by the user would still allow to grow.
Thus attempt an async resize in the background where we can allocate
using GFP_KERNEL which is more likely to succeed. The insertion itself
will still fail to indicate pressure.
This fixes a bug where the table would never continue growing once the
utilization is above 100%.
Fixes: ccd57b1bd324 ("rhashtable: Add immediate rehash during insertion")
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | lib/rhashtable.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/lib/rhashtable.c b/lib/rhashtable.c index 4898442b837f..f648cfde8520 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c @@ -410,8 +410,13 @@ int rhashtable_insert_rehash(struct rhashtable *ht) return -EBUSY; new_tbl = bucket_table_alloc(ht, size, GFP_ATOMIC); - if (new_tbl == NULL) + if (new_tbl == NULL) { + /* Schedule async resize/rehash to try allocation + * non-atomic context. + */ + schedule_work(&ht->run_work); return -ENOMEM; + } err = rhashtable_rehash_attach(ht, tbl, new_tbl); if (err) { |