diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-11-17 08:48:43 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2021-11-23 06:12:13 +0100 |
| commit | f0ae8685b2858fc1dabf5ea743642abb5f242375 (patch) | |
| tree | e9c7e9114873090f7d9a49ccae486bd61d5a2d36 | |
| parent | dt-bindings: phy: zynqmp-psgtr: fix USB phy name (diff) | |
| download | linux-f0ae8685b2858fc1dabf5ea743642abb5f242375.tar.xz linux-f0ae8685b2858fc1dabf5ea743642abb5f242375.zip | |
phy: HiSilicon: Fix copy and paste bug in error handling
This should check ">pmctrl" instead of "->sysctrl". This bug could
potentially lead to a crash if we dereference the error pointer.
Fixes: 73075011ffff ("phy: HiSilicon: Add driver for Kirin 970 PCIe PHY")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Link: https://lore.kernel.org/r/20211117074843.GE5237@kili
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/phy/hisilicon/phy-hi3670-pcie.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/hisilicon/phy-hi3670-pcie.c b/drivers/phy/hisilicon/phy-hi3670-pcie.c index c64c6679b1b9..0ac9634b398d 100644 --- a/drivers/phy/hisilicon/phy-hi3670-pcie.c +++ b/drivers/phy/hisilicon/phy-hi3670-pcie.c @@ -757,8 +757,8 @@ static int hi3670_pcie_phy_get_resources(struct hi3670_pcie_phy *phy, return PTR_ERR(phy->sysctrl); phy->pmctrl = syscon_regmap_lookup_by_compatible("hisilicon,hi3670-pmctrl"); - if (IS_ERR(phy->sysctrl)) - return PTR_ERR(phy->sysctrl); + if (IS_ERR(phy->pmctrl)) + return PTR_ERR(phy->pmctrl); /* clocks */ phy->phy_ref_clk = devm_clk_get(dev, "phy_ref"); |