diff options
| author | Jack Morgenstein <jackm@dev.mellanox.co.il> | 2012-05-30 11:14:54 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-06-01 00:18:16 +0200 |
| commit | 6230bb234dd17b4c92518e848368ce03f9802323 (patch) | |
| tree | 4cad586a9fbed1568a687fe5aa67124f11b3cf98 | |
| parent | net/mlx4_core: Fixes for VF / Guest startup flow (diff) | |
| download | linux-6230bb234dd17b4c92518e848368ce03f9802323.tar.xz linux-6230bb234dd17b4c92518e848368ce03f9802323.zip | |
net/mlx4_core: Check port out-of-range before using in mlx4_slave_cap
The range check was performed after using the port number.
Reverse this to prevent a potential array overflow.
Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlx4/main.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index 7f71be0ca5f2..ee6f4fe00837 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -485,15 +485,15 @@ static int mlx4_slave_cap(struct mlx4_dev *dev) dev->caps.num_mgms = 0; dev->caps.num_amgms = 0; - for (i = 1; i <= dev->caps.num_ports; ++i) - dev->caps.port_mask[i] = dev->caps.port_type[i]; - if (dev->caps.num_ports > MLX4_MAX_PORTS) { mlx4_err(dev, "HCA has %d ports, but we only support %d, " "aborting.\n", dev->caps.num_ports, MLX4_MAX_PORTS); return -ENODEV; } + for (i = 1; i <= dev->caps.num_ports; ++i) + dev->caps.port_mask[i] = dev->caps.port_type[i]; + if (dev->caps.uar_page_size * (dev->caps.num_uars - dev->caps.reserved_uars) > pci_resource_len(dev->pdev, 2)) { |