summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGUO Zihua <guozihua@huawei.com>2022-09-02 10:15:21 +0200
committerJakub Kicinski <kuba@kernel.org>2022-09-03 06:19:35 +0200
commitc8ef3c94bda0e21123202d057d4a299698fa0ed9 (patch)
treeb2a32ca70c888916c52c3bd7e6400e75ef5c8847
parentnet: sunplus: Fix return type for implementation of ndo_start_xmit (diff)
downloadlinux-c8ef3c94bda0e21123202d057d4a299698fa0ed9.tar.xz
linux-c8ef3c94bda0e21123202d057d4a299698fa0ed9.zip
net: lantiq_etop: Fix return type for implementation of ndo_start_xmit
Since Linux now supports CFI, it will be a good idea to fix mismatched return type for implementation of hooks. Otherwise this might get cought out by CFI and cause a panic. ltq_etop_tx() would return either NETDEV_TX_BUSY or NETDEV_TX_OK, so change the return type to netdev_tx_t directly. Signed-off-by: GUO Zihua <guozihua@huawei.com> Link: https://lore.kernel.org/r/20220902081521.59867-1-guozihua@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--drivers/net/ethernet/lantiq_etop.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 7cedbe1fdfd7..59aab4086dcc 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -470,7 +470,7 @@ ltq_etop_stop(struct net_device *dev)
return 0;
}
-static int
+static netdev_tx_t
ltq_etop_tx(struct sk_buff *skb, struct net_device *dev)
{
int queue = skb_get_queue_mapping(skb);