diff options
| author | Len Brown <len.brown@intel.com> | 2009-12-27 04:04:03 +0100 |
|---|---|---|
| committer | Len Brown <len.brown@intel.com> | 2009-12-30 08:48:52 +0100 |
| commit | f27725756be8a2c2dc65eaf70d0b52807aa2f113 (patch) | |
| tree | e8875a7dc8821c36759a2e27acc433cecd8b0069 | |
| parent | dell-wmi: sys_init_module: 'dell_wmi'->init suspiciously returned 21, it should (diff) | |
| download | linux-f27725756be8a2c2dc65eaf70d0b52807aa2f113.tar.xz linux-f27725756be8a2c2dc65eaf70d0b52807aa2f113.zip | |
ACPI: hp-wmi, msi-wmi: clarify that wmi_install_notify_handler() returns an acpi_status
Emphasize that that wmi_install_notify_handler() returns an acpi_status
rather than -errno by by testing ACPI_SUCCESS(), ACPI_FAILURE().
No functional change in this patch, but this confusion caused a bug in dell-wmi.
Signed-off-by: Len Brown <len.brown@intel.com>
| -rw-r--r-- | drivers/platform/x86/hp-wmi.c | 2 | ||||
| -rw-r--r-- | drivers/platform/x86/msi-wmi.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c index 8781d8fa7a57..18bf74136d24 100644 --- a/drivers/platform/x86/hp-wmi.c +++ b/drivers/platform/x86/hp-wmi.c @@ -581,7 +581,7 @@ static int __init hp_wmi_init(void) if (wmi_has_guid(HPWMI_EVENT_GUID)) { err = wmi_install_notify_handler(HPWMI_EVENT_GUID, hp_wmi_notify, NULL); - if (!err) + if (ACPI_SUCCESS(err)) hp_wmi_input_setup(); } diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c index 7f77f908bb01..f746c677adaa 100644 --- a/drivers/platform/x86/msi-wmi.c +++ b/drivers/platform/x86/msi-wmi.c @@ -236,7 +236,7 @@ static int __init msi_wmi_init(void) } err = wmi_install_notify_handler(MSIWMI_EVENT_GUID, msi_wmi_notify, NULL); - if (err) + if (ACPI_FAILURE(err)) return -EINVAL; err = msi_wmi_input_setup(); |