diff options
| author | Sandipan Das <sandipan@linux.ibm.com> | 2021-02-04 09:07:44 +0100 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2021-02-08 15:10:08 +0100 |
| commit | 22b89ba178dd0a66a26699ead014a3e73ff8e044 (patch) | |
| tree | 4dfc6f420e294d62c557926e5b8bd83348865354 | |
| parent | powerpc/sstep: Fix load-store and update emulation (diff) | |
| download | linux-22b89ba178dd0a66a26699ead014a3e73ff8e044.tar.xz linux-22b89ba178dd0a66a26699ead014a3e73ff8e044.zip | |
powerpc/sstep: Fix darn emulation
Commit 8813ff49607e ("powerpc/sstep: Check instruction validity
against ISA version before emulation") introduced a proper way to skip
unknown instructions. This makes sure that the same is used for the
darn instruction when the range selection bits have a reserved value.
Fixes: a23987ef267a ("powerpc: sstep: Add support for darn instruction")
Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210204080744.135785-2-sandipan@linux.ibm.com
| -rw-r--r-- | arch/powerpc/lib/sstep.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c index 11f14b209d7f..683f7c20f74b 100644 --- a/arch/powerpc/lib/sstep.c +++ b/arch/powerpc/lib/sstep.c @@ -1916,7 +1916,7 @@ int analyse_instr(struct instruction_op *op, const struct pt_regs *regs, goto compute_done; } - return -1; + goto unknown_opcode; #ifdef __powerpc64__ case 777: /* modsd */ if (!cpu_has_feature(CPU_FTR_ARCH_300)) |