diff options
| author | Shannon Nelson <snelson@pensando.io> | 2021-09-27 23:07:18 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-09-28 14:19:57 +0200 |
| commit | c23bb54f28d61a48008428e8cd320c947993919b (patch) | |
| tree | 1f6fe1cb8f6e92a0b3cc76c64f5ada0f011420c8 | |
| parent | Merge branch '1GbE' of git://git.kernel.org/pub/scm/linux/kernel/git/t (diff) | |
| download | linux-c23bb54f28d61a48008428e8cd320c947993919b.tar.xz linux-c23bb54f28d61a48008428e8cd320c947993919b.zip | |
ionic: fix gathering of debug stats
Don't print stats for which we haven't reserved space as it can
cause nasty memory bashing and related bad behaviors.
Fixes: aa620993b1e5 ("ionic: pull per-q stats work out of queue loops")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/pensando/ionic/ionic_stats.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_stats.c b/drivers/net/ethernet/pensando/ionic/ionic_stats.c index 58a854666c62..c14de5fcedea 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_stats.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_stats.c @@ -380,15 +380,6 @@ static void ionic_sw_stats_get_txq_values(struct ionic_lif *lif, u64 **buf, &ionic_dbg_intr_stats_desc[i]); (*buf)++; } - for (i = 0; i < IONIC_NUM_DBG_NAPI_STATS; i++) { - **buf = IONIC_READ_STAT64(&txqcq->napi_stats, - &ionic_dbg_napi_stats_desc[i]); - (*buf)++; - } - for (i = 0; i < IONIC_MAX_NUM_NAPI_CNTR; i++) { - **buf = txqcq->napi_stats.work_done_cntr[i]; - (*buf)++; - } for (i = 0; i < IONIC_MAX_NUM_SG_CNTR; i++) { **buf = txstats->sg_cntr[i]; (*buf)++; |