diff options
| author | Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> | 2015-12-17 05:32:23 +0100 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2015-12-21 03:41:49 +0100 |
| commit | ce360db703c98bd51fffe6f5d04a9e2294950514 (patch) | |
| tree | efc27d65fdfcd64ca4865546699384c411ec7e50 | |
| parent | Linux 4.4-rc6 (diff) | |
| download | linux-ce360db703c98bd51fffe6f5d04a9e2294950514.tar.xz linux-ce360db703c98bd51fffe6f5d04a9e2294950514.zip | |
ACPI / processor: Fix thermal cooling device regression
The processor cooling device is no longer present for passive thermal
control.
Commit 239708a3af44 ("ACPI: Split out ACPI PSS from ACPI Processor driver")
moved the processing to a new function acpi_pss_perf_init(), but
missed "return 0" after successful creation. This causes the error
handling functions to be called, which will delete the previously
created processor cooling device.
Fixes: 239708a3af44 (ACPI: Split out ACPI PSS from ACPI Processor driver)
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: 4.3+ <stable@vger.kernel.org> # 4.3+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/acpi/processor_driver.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c index f4e02ae93f58..11154a330f07 100644 --- a/drivers/acpi/processor_driver.c +++ b/drivers/acpi/processor_driver.c @@ -200,7 +200,8 @@ static int acpi_pss_perf_init(struct acpi_processor *pr, goto err_remove_sysfs_thermal; } - sysfs_remove_link(&pr->cdev->device.kobj, "device"); + return 0; + err_remove_sysfs_thermal: sysfs_remove_link(&device->dev.kobj, "thermal_cooling"); err_thermal_unregister: |