diff options
| author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-01-05 14:18:11 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-01-05 16:04:50 +0100 |
| commit | ff91e1b68490b97c18c649b769618815eb945f11 (patch) | |
| tree | 36cff3b5559f227b89192bdfa9f766467639d58f | |
| parent | mlxsw: pci: Avoid flow control for EMAD packets (diff) | |
| download | linux-ff91e1b68490b97c18c649b769618815eb945f11.tar.xz linux-ff91e1b68490b97c18c649b769618815eb945f11.zip | |
net: dsa: fix incorrect function pointer check for MRP ring roles
The cross-chip notifier boilerplate code meant to check the presence of
ds->ops->port_mrp_add_ring_role before calling it, but checked
ds->ops->port_mrp_add instead, before calling
ds->ops->port_mrp_add_ring_role.
Therefore, a driver which implements one operation but not the other
would trigger a NULL pointer dereference.
There isn't any such driver in DSA yet, so there is no reason to
backport the change. Issue found through code inspection.
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
Fixes: c595c4330da0 ("net: dsa: add MRP support")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/dsa/switch.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/dsa/switch.c b/net/dsa/switch.c index 393f2d8a860a..260d8e7d6e5a 100644 --- a/net/dsa/switch.c +++ b/net/dsa/switch.c @@ -729,7 +729,7 @@ static int dsa_switch_mrp_add_ring_role(struct dsa_switch *ds, struct dsa_notifier_mrp_ring_role_info *info) { - if (!ds->ops->port_mrp_add) + if (!ds->ops->port_mrp_add_ring_role) return -EOPNOTSUPP; if (ds->index == info->sw_index) @@ -743,7 +743,7 @@ static int dsa_switch_mrp_del_ring_role(struct dsa_switch *ds, struct dsa_notifier_mrp_ring_role_info *info) { - if (!ds->ops->port_mrp_del) + if (!ds->ops->port_mrp_del_ring_role) return -EOPNOTSUPP; if (ds->index == info->sw_index) |