summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWesley Cheng <wcheng@codeaurora.org>2021-05-07 19:55:19 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-05-10 14:54:48 +0200
commit18ffa988dbae69cc6e9949cddd9606f6fe533894 (patch)
tree79cbf2647bec35fb3fb8354bb2adb7e8b62be44e
parentusb: dwc3: gadget: Free gadget structure only after freeing endpoints (diff)
downloadlinux-18ffa988dbae69cc6e9949cddd9606f6fe533894.tar.xz
linux-18ffa988dbae69cc6e9949cddd9606f6fe533894.zip
usb: dwc3: gadget: Return success always for kick transfer in ep queue
If an error is received when issuing a start or update transfer command, the error handler will stop all active requests (including the current USB request), and call dwc3_gadget_giveback() to notify function drivers of the requests which have been stopped. Avoid returning an error for kick transfer during EP queue, to remove duplicate cleanup operations on the request being queued. Fixes: 8d99087c2db8 ("usb: dwc3: gadget: Properly handle failed kick_transfer") cc: stable@vger.kernel.org Signed-off-by: Wesley Cheng <wcheng@codeaurora.org> Link: https://lore.kernel.org/r/1620410119-24971-1-git-send-email-wcheng@codeaurora.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/dwc3/gadget.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index dd1342403bb2..49ca5da5e279 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1684,7 +1684,9 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *dep, struct dwc3_request *req)
}
}
- return __dwc3_gadget_kick_transfer(dep);
+ __dwc3_gadget_kick_transfer(dep);
+
+ return 0;
}
static int dwc3_gadget_ep_queue(struct usb_ep *ep, struct usb_request *request,