diff options
| author | Wei Wang <weiwan@google.com> | 2017-06-17 19:42:44 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-06-18 04:54:01 +0200 |
| commit | 44ebe79149ff415e810529bf192faa5c38d4a0de (patch) | |
| tree | 84d1cd1b7a6b3990749e2423a6a2a38a2478acd7 | |
| parent | net: reorder all the dst flags (diff) | |
| download | linux-44ebe79149ff415e810529bf192faa5c38d4a0de.tar.xz linux-44ebe79149ff415e810529bf192faa5c38d4a0de.zip | |
net: add debug atomic_inc_not_zero() in dst_hold()
This patch is meant to add a debug warning on the situation where dst is
being held during its destroy phase. This could potentially cause double
free issue on the dst.
Signed-off-by: Wei Wang <weiwan@google.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | include/net/dst.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/dst.h b/include/net/dst.h index d912b44d2dcb..f73611ec4017 100644 --- a/include/net/dst.h +++ b/include/net/dst.h @@ -251,7 +251,7 @@ static inline void dst_hold(struct dst_entry *dst) * __pad_to_align_refcnt declaration in struct dst_entry */ BUILD_BUG_ON(offsetof(struct dst_entry, __refcnt) & 63); - atomic_inc(&dst->__refcnt); + WARN_ON(atomic_inc_not_zero(&dst->__refcnt) == 0); } static inline void dst_use(struct dst_entry *dst, unsigned long time) |